Add hwp_pcu agent for the hwp phase compensation unit operations #588
Conversation
socs/agents/hwp_pcu/agent.py
Outdated
|
|
||
| **Task** - Send commands to the phase compensation unit. | ||
| off: The compensation phase is zero. | ||
| on_1:The compensation phase is +120 deg. |
There was a problem hiding this comment.
Why don't we change from 'on_1' to '＋120deg', 'on_2' to '-120deg'?
Is it not allowed in python?
At least I would like to change the status message.
There was a problem hiding this comment.
I think this might be fine as it is because "on_1" does not necessarily mean +120 deg. We intend to include the hwp_pcu in the hwp_supervisor, so more accurate compensated angle can be described in hwp_supervisor.
|
I think we also need to edit |
There was a problem hiding this comment.
Thank you for this really nice code! A few comments inline about usage of locking, and a couple of questions and requests:
- Do you think you can write up a docs page that includes the information from your slides about what this does / how to use it? You can check out existing doc pages like this for how these should be structured
- This agent structure, with multiple threads accessing a single hardware object with lock-outs is not really the best way to design an agent like this, as described in this discussion. I won't request that this agent is restructured if you don't want to since this is already very close to being mergeable, however if you are interested I am very happy to help restructure in such a way!
|
I have finished the requested modification of the code. The hardware is connected to nuc-hk1-satp3 over usb and the port is |
* hwp_pcu is added. * Update agent.py * Update agent.py * Update hwp_pcu.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update agent.py * make timeout longer and small fixes * fix get_status * fix send_command * add draft of docs * update draft of docs * small fixes of docs --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ykyohei <[email protected]>
The hwp_pcu agent controls the phase compensation unit (PCU) for the CHWP rotation system.
The PCU will be installed in the CHWP system of all SATs. The SAT2 has already successfully installed this unit.
I would like to add this hwp_pcu agent to the socs.
PCU increases the motor efficiency of the CHWP motor.
PCU can also stop the CHWP rotation without disabling the motor driving system.
The hardware and software of PCU are described in this slide.
This agent is tested in the lab, and will be tested with TSAT at site.
Hopefully this agent will be included in the hwp supervisor agent.